【pir】modify Call vjp interface for controlflow grad #58277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
approved these changes
Oct 23, 2023
| @@ -43,7 +43,13 @@ def test_tanh_vjp1(self): | |||
| out_grads = [[fill_constant_op.result(0)]] | |||
| stop_gradients = [[False]] | |||
| with paddle.pir.core.program_guard(newir_program): | |||
| grad_outs = call_vjp(tanh_op, out_grads, stop_gradients) | |||
| grad_outs = call_vjp( | |||
There was a problem hiding this comment.
call_vjp 后续会提供两种形态的API么，一种是对于非控制流，可以不显式地指定inputs和outputs，这样使用起来更方便；也有一种是需要指定inputs和outputs的，扩展支持控制流的？
There was a problem hiding this comment.
目前是对非控制流op call_vjp改造；这些op在控制流block中需要修改call_vjp的输入. 控制流的op调用反向的接口使用其他接口，只负责返回反向空op, 复用ir_backward 逻辑填加其他op的反向op
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Oct 24, 2023
* tmp * [PIR]Migrate maximum into pir * Polish code * add ir_grad of static_gradient * add test * modify bug * modify * add mean fill_constant test * modify cpu int32 test * get_shape_tensor * delete * add default place * modify grad * modify call_vjp * Update python/paddle/autograd/ir_backward.py * fix name * new ci --------- Co-authored-by: 0x45f <wangzhen45@baidu.com>
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 26, 2023
* tmp * [PIR]Migrate maximum into pir * Polish code * add ir_grad of static_gradient * add test * modify bug * modify * add mean fill_constant test * modify cpu int32 test * get_shape_tensor * delete * add default place * modify grad * modify call_vjp * Update python/paddle/autograd/ir_backward.py * fix name * new ci --------- Co-authored-by: 0x45f <wangzhen45@baidu.com>
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* tmp * [PIR]Migrate maximum into pir * Polish code * add ir_grad of static_gradient * add test * modify bug * modify * add mean fill_constant test * modify cpu int32 test * get_shape_tensor * delete * add default place * modify grad * modify call_vjp * Update python/paddle/autograd/ir_backward.py * fix name * new ci --------- Co-authored-by: 0x45f <wangzhen45@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
others
PR changes
others
Description
pcard-67164
修改call_vjp增加前向输入输出参数，控制流反向子block无法访问前向block中的输入输出变量，需要访问copy变量，因此在ir_backward中提供