[SOT][3.11] fix pass NULL to resume function in jump breakgraph
#58187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
changed the title
NULL pass to resume function in jump breakgraphNULL to resume function in jump breakgraph
zrr1999
approved these changes
Oct 18, 2023
SigureMo
deleted the
sot/fix-311-null-pass-to-resume-in-jump-breakgraph
branch
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Oct 24, 2023
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 26, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
当发生子图打断的时候，是有可能将 NULL 恢复到栈上的（生成代码），一旦将 NULL 恢复到栈上并作为参数传递给后续的 resume function，就会触发段错误
之前我们对 call breakgraph 做了如果 resume 参数是 NULL 则改为 NullVariable 的处理，但在 3.11 中 jump breakgraph 有同样的问题，因此对 jump breakgraph 做同样的修复
PCard-66972