[PIR] test_ifelse ut add pir test branch #58163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
reviewed
Oct 18, 2023
| @@ -259,6 +259,9 @@ pir::OpInfo OpTranscriber::LoopkUpOpInfo(pir::IrContext* ctx, | |||
| continue; | |||
| } | |||
| VarDesc* var = op_desc.Block()->FindVarRecursive(legacy_input_vars[0]); | |||
| IR_ENFORCE(var != nullptr, | |||
| "Can't find var recursivelly from current block."); | |||
There was a problem hiding this comment.
Suggested change
| "Can't find var recursivelly from current block."); | |
| "Can't find var recursively from current block."); |
| return self._run_dygraph(to_static=True) | ||
|
|
||
| def _run_dygraph(self, to_static=False): | ||
| with base.dygraph.guard(place): |
There was a problem hiding this comment.
这里新增的代码可以按照Paddle最新的API来写。比如：
- base.dygraph.guard → paddle.set_device()
- to_variable → to_tensor
|
|
||
| def _run_dygraph(self, to_static=False): | ||
| with base.dygraph.guard(place): | ||
| x_v = base.dygraph.to_variable(self.x) |
Aurelius84
approved these changes
Oct 19, 2023
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Oct 24, 2023
* fix * fix * fix * fix * fix * fix * fix * fix bug * fix bug * fix bug * fix bug * fix bug * add * fix * fix * fix * fix * refine code
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 26, 2023
* fix * fix * fix * fix * fix * fix * fix * fix bug * fix bug * fix bug * fix bug * fix bug * add * fix * fix * fix * fix * refine code
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* fix * fix * fix * fix * fix * fix * fix * fix bug * fix bug * fix bug * fix bug * fix bug * add * fix * fix * fix * fix * refine code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
随着 PIR 完成对 IF 前向执行的支持，将 test_ifelse 单测添加 PIR 的测试分支
TODO：本 PR 尚有5个测试 case 待开启 PIR 的测试分支，具体包括：
Pcard-67164