Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CustomDevice] remove destroy event to avoid cpu blocking in ~XCCLTask #58038

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

ronny1996
Copy link
Contributor

@ronny1996 ronny1996 commented Oct 12, 2023

PR types

Bug fixes

PR changes

Others

Description

Fix blocking cpu in ~XCCLTask

  1. phi::event::Event 析构函数时增加 sync(如果需要),防止插件侧复用调用stream_wait_event 的 event 时永远无法完成
  2. ProcessGroupCustom::XCCTask 析构函数中不再销毁 phi::event::Event,防止 destroy_event 阻塞CPU ,以及插件侧复用event时,引发 1 问题

@paddle-bot
Copy link

paddle-bot bot commented Oct 12, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@ronny1996 ronny1996 changed the title [CustomDevice] Fix blocking cpu in ~XCCLTask [CustomDevice] remove destroy event to avoid cpu blocking in ~XCCLTask Oct 12, 2023
@ronny1996 ronny1996 merged commit ccdf25d into PaddlePaddle:develop Oct 13, 2023
@ronny1996 ronny1996 deleted the fix_pg_event branch October 13, 2023 02:17
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants