Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix explicit quantization conv2d error #58015

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

leo0519
Copy link
Collaborator

@leo0519 leo0519 commented Oct 11, 2023

PR types

Bug fixes

PR changes

Others

Description

Refer to issue-57935.
Paddle develop already supported that the filter of conv2d is a temporary tensor.
This PR removed redundant modifications in PR-57160.

@paddle-bot
Copy link

paddle-bot bot commented Oct 11, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@leo0519
Copy link
Collaborator Author

leo0519 commented Oct 12, 2023

  • PR-CI-APPROVAL:
2023-10-11 16:23:05 0. You must have one QA (XieYunshen(Recommend) or chalsliu) approval for setting parameter RUN_TYPE as EXCLUSIVE, DIST, NIGHTLY, EXCLUSIVE:NIGHTLY or DISTNIGHTLY, or setting parameter SERIAL, or setting TIMEOUT properties.
  • PR-CI-Coverage: The environment TRT version is too low to test this PR (should be exempted).

Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for set_tests_properties(test_trt_explicit_quantization_resnet PROPERTIES TIMEOUT 300) set_tests_properties(test_trt_explicit_quantization_mobilenet PROPERTIES TIMEOUT 300)

@Wangzheee Wangzheee merged commit 4a53f1b into PaddlePaddle:develop Oct 13, 2023
28 checks passed
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
* Fix explicit quantization conv2d error
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
* Fix explicit quantization conv2d error
@paddle-bot paddle-bot bot removed the contributor External developers label Nov 3, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* Fix explicit quantization conv2d error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants