add unittest for dataparallel bf16 O2 main_grad #57967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
FeixLiu
reviewed
Oct 17, 2023
| @@ -754,6 +754,8 @@ void EagerReducer::AddDistHook(size_t var_index) { | |||
| auto &group = groups_[group_index]; | |||
| auto &group_tensor = group.dense_tensors_[inside_group_index]; | |||
|
|
|||
| if (!group_tensor.initialized()) return; | |||
There was a problem hiding this comment.
这个可以不要了，在这个pr里修复了：#57960 。可以rebase一下最新develop～
tianhaodongbd
force-pushed
the
dp_bf16
branch
from
4d5e23a
to
bfabcb3
Compare
FeixLiu
approved these changes
Oct 17, 2023
XieYunshen
approved these changes
Oct 18, 2023
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Oct 24, 2023
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 26, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
添加DP支持BF16 O2 main_grad的单测，验证方式和BF16 O1+白名单对比
PCard-70444