-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【pir】Add pir_grad branch for paddle.static.gradient for test #57956
【pir】Add pir_grad branch for paddle.static.gradient for test #57956
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
# paddle.base.default_main_program = ( | ||
# paddle.pir.core.default_main_program | ||
# ) | ||
# paddle.base.default_startup_program = ( | ||
# paddle.pir.core.default_startup_program | ||
# ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没用的注释可以删掉
# paddle.base.default_main_program = self.old_default_main_program | ||
# paddle.base.default_startup_program = ( | ||
# self.old_default_startup_program | ||
# ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
此处注释为提醒遗留处理项
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议删除或者打开注释,或者是标记加TODO
from functools import wraps | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里很奇怪,因为上午有pr已经这里有代码合入了,这里居然没有产生代码冲突?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个是拉取同一个pr的代码
d625d3e
into
PaddlePaddle:develop
…addle#57956) * tmp * [PIR]Migrate maximum into pir * Polish code * add ir_grad of static_gradient * add test * modify bug * modify --------- Co-authored-by: 0x45f <wangzhen45@baidu.com>
…addle#57956) * tmp * [PIR]Migrate maximum into pir * Polish code * add ir_grad of static_gradient * add test * modify bug * modify --------- Co-authored-by: 0x45f <wangzhen45@baidu.com>
…addle#57956) * tmp * [PIR]Migrate maximum into pir * Polish code * add ir_grad of static_gradient * add test * modify bug * modify --------- Co-authored-by: 0x45f <wangzhen45@baidu.com>
PR types
Others
PR changes
Others
Description
pcard-67164
为paddle.static.gradient api 增加新IR 分支
备注: