Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【pir】Add pir_grad branch for paddle.static.gradient for test #57956

Merged
merged 15 commits into from
Oct 10, 2023

Conversation

xiaoguoguo626807
Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 commented Oct 9, 2023

PR types

Others

PR changes

Others

Description

pcard-67164
为paddle.static.gradient api 增加新IR 分支

备注:
image

@paddle-bot
Copy link

paddle-bot bot commented Oct 9, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@xiaoguoguo626807 xiaoguoguo626807 changed the title Add grad 【pir】Add pir_grad branch for paddle.static.gradient for test Oct 9, 2023
Comment on lines +72 to +77
# paddle.base.default_main_program = (
# paddle.pir.core.default_main_program
# )
# paddle.base.default_startup_program = (
# paddle.pir.core.default_startup_program
# )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没用的注释可以删掉

Comment on lines +97 to +100
# paddle.base.default_main_program = self.old_default_main_program
# paddle.base.default_startup_program = (
# self.old_default_startup_program
# )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处注释为提醒遗留处理项

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议删除或者打开注释,或者是标记加TODO

Comment on lines +16 to +17
from functools import wraps

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里很奇怪,因为上午有pr已经这里有代码合入了,这里居然没有产生代码冲突?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是拉取同一个pr的代码

@xiaoguoguo626807 xiaoguoguo626807 merged commit d625d3e into PaddlePaddle:develop Oct 10, 2023
26 of 27 checks passed
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
…addle#57956)

* tmp

* [PIR]Migrate maximum into pir

* Polish code

* add ir_grad of static_gradient

* add test

* modify bug

* modify

---------

Co-authored-by: 0x45f <wangzhen45@baidu.com>
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
…addle#57956)

* tmp

* [PIR]Migrate maximum into pir

* Polish code

* add ir_grad of static_gradient

* add test

* modify bug

* modify

---------

Co-authored-by: 0x45f <wangzhen45@baidu.com>
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
…addle#57956)

* tmp

* [PIR]Migrate maximum into pir

* Polish code

* add ir_grad of static_gradient

* add test

* modify bug

* modify

---------

Co-authored-by: 0x45f <wangzhen45@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants