Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PIR] No.46 Migrate paddle.tile into pir #57700

Merged
merged 8 commits into from
Sep 26, 2023
Merged

[PIR] No.46 Migrate paddle.tile into pir #57700

merged 8 commits into from
Sep 26, 2023

Conversation

zrr1999
Copy link
Member

@zrr1999 zrr1999 commented Sep 25, 2023 •
edited
Loading

PR types

Others

PR changes

APIs

Description

[PIR] No.46 Migrate paddle.tile into pir
总计 27 个单测，打开20个单测，7个单测继承自unittest.TestCase没有覆盖到。

@paddle-bot
Copy link

paddle-bot bot commented Sep 25, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 25, 2023
@paddle-bot
Copy link

paddle-bot bot commented Sep 25, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@zrr1999 zrr1999 changed the title [PIR]Migrate tile into pir [PIR] No.46 Migrate paddle.tile into pir Sep 25, 2023
@zrr1999 zrr1999 mentioned this pull request Sep 25, 2023
Closed
@0x45f
Copy link
Contributor

0x45f commented Sep 25, 2023

代码风格检查挂了，在本地pre-commit下吧

@zrr1999
Copy link
Member Author

zrr1999 commented Sep 25, 2023

代码风格检查挂了，在本地pre-commit下吧

好的，已修复

@0x45f
Copy link
Contributor

0x45f commented Sep 25, 2023

看报错tile还没有生成反向的接口，麻烦在vjp_interface_gen_op_list.py文件的两个list中都加上tile；在paddle/fluid/primitive/codegen/gen.py文件的VJPS和BACKENDS中加上tile_grad ~

@zrr1999
Copy link
Member Author

zrr1999 commented Sep 25, 2023

看报错tile还没有生成反向的接口，麻烦在vjp_interface_gen_op_list.py文件的两个list中都加上tile；在paddle/fluid/primitive/codegen/gen.py文件的VJPS和BACKENDS中加上tile_grad ~

好的已添加

@0x45f
Copy link
Contributor

0x45f commented Sep 26, 2023

看报错tile还没有生成反向的接口，麻烦在vjp_interface_gen_op_list.py文件的两个list中都加上tile；在paddle/fluid/primitive/codegen/gen.py文件的VJPS和BACKENDS中加上tile_grad ~

好的已添加

gen.py文件似乎没有修改，可以修改一下~

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Sep 26, 2023
@0x45f
Copy link
Contributor

0x45f commented Sep 26, 2023

解决了冲突

@0x45f 0x45f merged commit 53e07af into PaddlePaddle:develop Sep 26, 2023
27 checks passed
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
@zrr1999 @Frida-a
[PIR] No.46 Migrate paddle.tile into pir (PaddlePaddle#57700)
8d8faf4
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
@zrr1999 @jiahy0825
[PIR] No.46 Migrate paddle.tile into pir (PaddlePaddle#57700)
5a3987b
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@zrr1999
[PIR] No.46 Migrate paddle.tile into pir (PaddlePaddle#57700)
ea14bfc
@YuanRisheng YuanRisheng mentioned this pull request Mar 11, 2024
Closed
@risemeup1 risemeup1 mentioned this pull request May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x45f 0x45f 0x45f approved these changes

Assignees

@luotao1 luotao1

@0x45f 0x45f

@YuanRisheng YuanRisheng

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zrr1999 @0x45f @luotao1 @YuanRisheng