fix RunWithExternalStream contex switch bug #57629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
chenwhql
reviewed
Sep 22, 2023
| @@ -71,6 +71,8 @@ class PADDLE_API DeviceContextPool { | |||
|
|
|||
| phi::DeviceContext* GetMutable(const Place& place); | |||
|
|
|||
| void Update(const Place& place); | |||
There was a problem hiding this comment.
如果确实需要增加的话，建议再斟酌一下接口名，仅看代码Update不太清楚是更新了什么，可以具体一点，我理解这里应该是底层的DeviceContext更新了，但是没有同步到API层对吧，所以是不是SyncDeviceContextPointer之类的更准确，仅供参考，根据实际语义命名即可
chenwhql
previously approved these changes
Sep 22, 2023
chenwhql
approved these changes
Sep 25, 2023
Wangzheee
approved these changes
Sep 25, 2023
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
* fix RunWithExternalStream contex switch bug
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 16, 2023
* fix RunWithExternalStream contex switch bug
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* fix RunWithExternalStream contex switch bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-71501
修复bug：
RunWithExternalStream接口在调用的时候，新建的DeviceContext没有更新在paddle::experimental::DeviceContextPool中，导致在调用empty创建tensor的时候发生core dump。