Add IsMean template parameter for compile #57558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
AnnaTrainingG
force-pushed
the
reduce
branch
from
80efc23 to
6bc8f48
Compare
AnnaTrainingG
force-pushed
the
reduce
branch
from
841e553 to
65b5dcd
Compare
Xreki
reviewed
Sep 24, 2023
| {0, 1}, | ||
| stream); | ||
| phi::SumKernel<T>( | ||
| dev_ctx_, *d_output, {0, 1}, d_output->dtype(), false, d_bias); |
There was a problem hiding this comment.
第4个参数应该传输出的dtype，虽然大部分情况下输入、输出的dtype一样，但还是按照参数的语义来传比较好
| @@ -14,14 +14,14 @@ limitations under the License. */ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include "paddle/fluid/operators/reduce_ops/reduce_op.cu.h" | |||
There was a problem hiding this comment.
fluid实际上只有这个文件用到了reduce_op.cu.h，后面可以提个PR移除reduce_op.cu.h文件。- 已经存在
paddle/phi/kernels/fusion/gpu/attn_gemm.h，fluid下面的这个头文件是不是可以删除了？
There was a problem hiding this comment.
是的，这部分会在下个PR 统一修改，避免功能修改混乱
| {0, 1, 2}, | ||
| stream); | ||
| phi::SumKernel<T>( | ||
| dev_ctx_, *d_output, {0, 2}, d_output->dtype(), false, d_bias); |
There was a problem hiding this comment.
左边删除代码中的reduce_dim是{0, 1, 2}
| class ReduceOp, | ||
| typename TransformOp, | ||
| bool IsMean = false> | ||
| struct CubTensorReduce; |
There was a problem hiding this comment.
false的实现（L1012 - L1027）可以合并到这里，不用单独特化，只需特化true的实现。
AnnaTrainingG
force-pushed
the
reduce
branch
from
73dff53 to
dd49e9a
Compare
Xreki
approved these changes
Sep 25, 2023
| {0, 1}, | ||
| stream); | ||
| phi::SumKernel<T, phi::GPUContext>( | ||
| dev_ctx_, *d_output, {0, 1}, d_output->dtype(), false, d_bias); |
There was a problem hiding this comment.
这里第4个参数out_dtype，应该是d_bias的dtype
There was a problem hiding this comment.
之前体积的统计是在没修改sumKernel的情况下统计的
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 16, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-70459
本PR主要修改是将reduce_function.h中关于cubReduce的调用从is_mean普通参数判断调整为模板参数判断。
只有在ReduceMean OP 中才能将模板参数中的IsMean设置为True, 其他情况默认是False
本PR的修改原理，避免非ReduceMeanOP对于DivFunctor的编译例化,导致CubReduce的相关编译体积过大。
libphi.a的体积减少为： 5M ： 872->867