[PIR] Refine Op Build by invoke info #57480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
cyber-pioneer
previously approved these changes
Sep 19, 2023
zyfncg
reviewed
Sep 19, 2023
Comment on lines
150
to
151
| if op_class_name == "PowOp": | ||
| rtn = "paddle::dialect::TransToPhiDataType(x_.type().dyn_cast<paddle::dialect::DenseTensorType>().dtype())" |
There was a problem hiding this comment.
其特点是y 要与 x 是相同 dtype，暂未发现其他类似问题的算子
There was a problem hiding this comment.
二元运算的算子大部分都有这个约束吧？像add, multiply这些
zyfncg
approved these changes
Sep 20, 2023
iosmers
pushed a commit
to iosmers/Paddle
that referenced
this pull request
Sep 21, 2023
* refine code * refine code * refine code * refine
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
* refine code * refine code * refine code * refine
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* refine code * refine code * refine code * refine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
依据 yaml 的invoke 信息完善 Op Build接口
Pcard-67164