-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Semi Auto] Refactor Completion Mechanism (Part1) #57447
Merged
zhiqiu
merged 21 commits into
PaddlePaddle:develop
from
JZ-LIANG:semi-auto/completion-I
Sep 26, 2023
Merged
[Semi Auto] Refactor Completion Mechanism (Part1) #57447
zhiqiu
merged 21 commits into
PaddlePaddle:develop
from
JZ-LIANG:semi-auto/completion-I
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献! |
JZ-LIANG
changed the title
[Semi Auto] Refactor Completion Mechanism
[Semi Auto] Refactor Completion Mechanism I
Sep 21, 2023
JZ-LIANG
changed the title
[Semi Auto] Refactor Completion Mechanism I
[Semi Auto] Refactor Completion Mechanism Part1
Sep 21, 2023
JZ-LIANG
changed the title
[Semi Auto] Refactor Completion Mechanism Part1
[Semi Auto] Refactor Completion Mechanism (Part1)
Sep 21, 2023
JZ-LIANG
changed the title
[Semi Auto] Refactor Completion Mechanism (Part1)
[Semi Auto] Refactor Completion Mechanism (Part1)
Sep 21, 2023
zhiqiu
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
* first commit * framework * matmul done * elementwise done * adapt done * polish code * revise logging * revise log * update doc * enable LN unitest * precommit * bugfix reduce_sum * bugfix assign * bugfix for print program * enable rule for dropout * bugfix for dist op
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 16, 2023
* first commit * framework * matmul done * elementwise done * adapt done * polish code * revise logging * revise log * update doc * enable LN unitest * precommit * bugfix reduce_sum * bugfix assign * bugfix for print program * enable rule for dropout * bugfix for dist op
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* first commit * framework * matmul done * elementwise done * adapt done * polish code * revise logging * revise log * update doc * enable LN unitest * precommit * bugfix reduce_sum * bugfix assign * bugfix for print program * enable rule for dropout * bugfix for dist op
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Description
Pcard-70448
Refactor the Op internal dims mapping update Logic:
the new logic would has two main branch:
left: orignal logic for ops that has not new spmd rule
right: new logic for ops that has new spmd rule implemented.
How we plan to refactor static mode Semi Auto Parallel:
Currently:
there are 3 problems:
After Refactor Completion (This and next PRs):
After Refactor DistOperatorImpl (Future PRs):