fix detach_ bug #57394
Merged
fix detach_ bug #57394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
kangguangli
reviewed
Sep 15, 2023
| @@ -1118,7 +1118,7 @@ static PyObject* tensor_method_detach_(TensorObject* self, | |||
| autograd_meta->SetPersistable( | |||
| egr::EagerUtils::autograd_meta(&(self->tensor))->Persistable()); | |||
| self->tensor.set_autograd_meta(autograd_meta); | |||
|
|
|||
| Py_INCREF(reinterpret_cast<PyObject*>(self)); | |||
There was a problem hiding this comment.
这里我不太了解，为什么需要把引用计数加1呢？需要添加对应的 Py_DECREF吗？
There was a problem hiding this comment.
因为self返回作为result返回后，在Python端相当于多了一个object。而这个object析构，会触发一次引用计数--。
如果这里不加1，引用计数归零，这个对象就被释放了。但Python端还有一个object没有系统。在Python运行结束，这个object析构时，就double free了。
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
detach_对PyObject*的引用计数处理错误。本PR修复
Pcard-74613