[NewIR] No.33, 34 Migrate paddle.shape, paddle.numel into pir #57330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangjiyi
commented
Sep 14, 2023
| class Test1NumelOpComplex64(TestNumelOpComplex): | ||
| class TestNumelOp1Complex64(TestNumelOpComplex): |
There was a problem hiding this comment.
改这些单测的名字是因为 unittest 好像是按照文件中单测名字的顺序执行每个单测的，然后改之前 Test1NumelOpComplex64 这几个单测执行在 TestNumelAPI 的前面，同时在加上 check_new_ir=True 后 check_output 会把当前环境下的 static_mode 变为 dynamic_mode，导致应该在 static_mode 下执行的 TestNumelAPI 变成在 dynamic_mode 下执行，然后就报错了
加上 check_new_ir=True 后 check_output 改变 static_mode 的相关代码我定位了，但我不知道这是不是正常的：
Paddle/python/paddle/new_ir_utils.py
Lines 42 to 45 in ce825f4
Closed
0x45f
approved these changes
Sep 15, 2023
Aurelius84
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description