[AutoParallel]: Support multi kernels for DistTensor. #57321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is not supported now.
chenwhql
reviewed
Sep 14, 2023
| @@ -1014,7 +1014,29 @@ def gene_base_api_code(self, inplace_flag=False): | |||
| api_func_name += '_' | |||
|
|
|||
| if len(self.kernel['func']) > 1: | |||
| # auto parallel branch, all apis contains this branch default | |||
| # 1. only works for the ops contains single kernel | |||
There was a problem hiding this comment.
这里的注释可以整体移到if条件前，只保留一份，有些已经支持了的建议根据实际情况清理一下
| @@ -426,6 +426,62 @@ def test_adamax_for_dist_tensor(self): | |||
| self.check_tensor_eq(local_inf_norm_out, dist_inf_norm_out) | |||
| self.check_tensor_eq(local_master_param_out, dist_master_param_out) | |||
|
|
|||
| # multi kernel functions | |||
| def test_adagrad_for_dist_tensor(self): | |||
There was a problem hiding this comment.
后面咱们这个咱们可以把测试API的单独移到一个文件中，比如叫test_api_dist_branch.py什么的，test_dist_tensor的语义范围好像不太能覆盖了
There was a problem hiding this comment.
新增了一个test_api_dist_branch.py，把多类型的API生成单测，以及多kernel的单测都迁移过去了
… support_multi_kernel
chenwhql
approved these changes
Sep 18, 2023
|
收到，单测没跑到的话，我在PR 57293一起改了 |
LiYuRio
reviewed
Sep 18, 2023
Comment on lines
+1034
to
+1035
| and not self.api.endswith("_double_grad") | ||
| and not self.api.endswith("_triple_grad") |
There was a problem hiding this comment.
这不止跳过了sparse的貌似，还判断了高阶 微分和自动并行
There was a problem hiding this comment.
收到，我在PR 57293里改一下
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
…7321) * [AutoParallel]: Support multi kernels for DistTensor. Sparse kernel is not supported now. * Polish code with review comments. :wq * Add testcases.
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
…7321) * [AutoParallel]: Support multi kernels for DistTensor. Sparse kernel is not supported now. * Polish code with review comments. :wq * Add testcases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-73145
Support multi kernels for DistTensor. Sparse kernel is not supported now.