fix parse string #57314
Merged
fix parse string #57314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
kangguangli
reviewed
Sep 18, 2023
paddle/pir/core/parser/lexer.cc
Outdated
Comment on lines
181
to
183
| if (c == '\\') { | ||
| c = GetChar(); | ||
| } |
kangguangli
reviewed
Sep 19, 2023
|
|
||
| //CHECK attribute | ||
| (Array)[(Double)1,(Int64)0,(String)1] | ||
| (Array)[(Double)1,(Int64)0,"1"] |
There was a problem hiding this comment.
Suggested change
| (Array)[(Double)1,(Int64)0,"1"] | |
| [(Double)1,(Int64)0,"1"] |
接下来还需要优化下针对Array的parser，跟String类似，我们通过[]应该就可以识别，感觉没必要加一个Array，比较累赘
There was a problem hiding this comment.
另外针对String Attribute补充一些测试用例吧，比如
Suggested change
| (Array)[(Double)1,(Int64)0,"1"] | |
| “\“” | |
| "\\"" | |
| "\\\"" | |
| "\t\r\n\"" |
之类的
iosmers
pushed a commit
to iosmers/Paddle
that referenced
this pull request
Sep 21, 2023
* fix parse string * fix parse string * fix string * fix string * fix string * fix string * fix codestyle * fix string * fix parse string --------- Co-authored-by: xingmingyyj <zxm_3719@163.com>
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
* fix parse string * fix parse string * fix string * fix string * fix string * fix string * fix codestyle * fix string * fix parse string --------- Co-authored-by: xingmingyyj <zxm_3719@163.com>
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* fix parse string * fix parse string * fix string * fix string * fix string * fix string * fix codestyle * fix string * fix parse string --------- Co-authored-by: xingmingyyj <zxm_3719@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
修改StringAttribute的print和parse方式，StringAttribute的值按\“StringVal\”的形式print,如果StringVal中含有字符"，进行转义，按"方式输出
在
test/cpp/pir/core/TestParserText.txt给出样例