[NewIR] No.40-41 Migrate paddle.tanh and paddle.transpose into pir #57248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
tanh对应的单测只有test/cinn/ops/test_tanh_op.py，是在这里进行单测验证的吗？ |
longranger2
changed the title
Closed
在test/legacy_test/test_activation_op.py里，有个TestTanh的单测 |
There was a problem hiding this comment.
transpose前向到反向的调用已经支持：#57279，可以拉取最新代码进行rerun
|
|
||
| def test_check_grad(self): | ||
| self.check_grad(['X'], 'Out', check_prim=True) | ||
| self.check_grad(['X'], 'Out', check_prim=True, check_new_ir=True) | ||
|
|
There was a problem hiding this comment.
transpose的单测还有一些未开启，请将此文件中所有涉及transpose算子的单测开启new_ir flag
|
@changeyoung98 辛苦review下～ |
changeyoung98
approved these changes
Sep 18, 2023
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
…addlePaddle#57248) * tanh and transpose in new ir * fix tanh test * Update test_transpose_op.py
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
…addlePaddle#57248) * tanh and transpose in new ir * fix tanh test * Update test_transpose_op.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
Migrate paddle.tanh into pir
Migrate paddle.transpose into pir
【开源任务】新 IR API 推全升级 #57097