Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NewIR]Remove grad apis in c_ops #57158

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Conversation

0x45f
Copy link
Contributor

@0x45f 0x45f commented Sep 10, 2023

PR types

Others

PR changes

Others

Description

移除了一些python端不需要的api的生成,比如反向的grad api

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Sep 10, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@0x45f 0x45f changed the title Remove grad apis in c_ops [NewIR]Remove grad apis in c_ops Sep 11, 2023
Aurelius84
Aurelius84 previously approved these changes Sep 11, 2023
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

def _need_skip(self, op_info, op_name):
return (
super()._need_skip(op_info, op_name)
or op_name.endswith('_grad')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endswith 是支持多个一起判断的,如

op_name.endswith(('_grad', '_grad_','xpu'))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no docs changes

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit b14202b into PaddlePaddle:develop Sep 12, 2023
@0x45f 0x45f deleted the remove-cpp-api branch September 12, 2023 04:50
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants