Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ShapeOptimizationPass for SymbolicDim constraint construction. #57069

Merged
merged 12 commits into from
Sep 15, 2023
Merged

Add ShapeOptimizationPass for SymbolicDim constraint construction. #57069

merged 12 commits into from
Sep 15, 2023

Conversation

liuruyan
Copy link
Contributor

@liuruyan liuruyan commented Sep 7, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

  1. 新增 paddle/pir/dialect/shape/transforms 文件夹存放 ShapeDialect 相关 Pass。
  2. 新建 ShapeOptimizationPass 用作约束建立 。
  3. 新增 test/cpp/pir/shape_dialect/constraint_pass_test.cc 作为 ShapeDialcet 相关 Pass 单测文件。
  4. 新增 TensorDimOp，功能为取出 TensorShape 具体维度。
  5. 补齐 TieShapeOp 功能：绑定 Dim。（暂时不绑定 Dim 的构造函数仍然保留，用作 Debug）
  6. 新增 MaterializeShapeComputation 完成 Shape 具象化，目前完成 InsertTieShape 部分，剩余 ReifyInferShape 部分。
  7. 根据 Paddle 代码规范，规范化 ShapeDialect 相关代码。

Other

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Sep 7, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@liuruyan liuruyan changed the title add ShapeOptimizationPass for SymbolicDim Constraint construction. Add ShapeOptimizationPass for SymbolicDim constraint construction. Sep 14, 2023
@zhangbopd
Copy link
Contributor

LGTM，PR comment 下一个PR改一下吧

@zhangbopd zhangbopd merged commit d499021 into PaddlePaddle:develop Sep 15, 2023
@liuruyan liuruyan deleted the simple_pass branch September 15, 2023 02:41
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@liuruyan
Add ShapeOptimizationPass for SymbolicDim constraint construction. (P…
d39553a 
…addlePaddle#57069)

* add constraint_pass for symbolicDim construction.

* add UT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aurelius84 Aurelius84 Aurelius84 left review comments

@winter-wang winter-wang winter-wang left review comments

@zhangbopd zhangbopd zhangbopd left review comments

@zhangbo9674 zhangbo9674 zhangbo9674 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liuruyan @zhangbopd @Aurelius84 @winter-wang @zhangbo9674