Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【CINN】Rewrite tensor_writer_teller #57019

Merged
merged 7 commits into from
Sep 12, 2023

Conversation

Courtesy-Xs
Copy link
Contributor

@Courtesy-Xs Courtesy-Xs commented Sep 6, 2023

PR types

Others

PR changes

Others

Description

pcard-72718
This PR refactor tensor_writer_teller

@paddle-bot
Copy link

paddle-bot bot commented Sep 6, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -65,5 +65,7 @@ std::map<std::string, Expr> CollectTensorMap(
return true;
});

std::set<std::string> CollectTensorNeedsWrite(const Expr* e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加一下函数功能注释

Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Courtesy-Xs Courtesy-Xs merged commit 3a34a9c into PaddlePaddle:develop Sep 12, 2023
Courtesy-Xs added a commit that referenced this pull request Sep 12, 2023
@Courtesy-Xs Courtesy-Xs deleted the move_tensor_writer_tell branch September 14, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants