Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete fleet executor test #56951

Merged

Conversation

risemeup1
Copy link
Contributor

@risemeup1 risemeup1 commented Sep 5, 2023

PR types

Others

PR changes

Others

Description

Pcard-67010
fleet_executor/test/目录下的单测编译出来的可执行文件达4.2G,导致Coverage 流水线因为内存占满出现kill -9的bug,将这些单测依赖libpaddle.so后仍然不能解决问题,因为这些单测仍然需要依赖fleet_executor,因为fleet_executor中的符号没有打进libpaddle.so,如果将fleet_exectuor打到libpaddle.so,会导致so体积和whl包体积增大,所以临时不编译这些异步执行器单测

@paddle-bot
Copy link

paddle-bot bot commented Sep 5, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@risemeup1 risemeup1 merged commit c71f5f9 into PaddlePaddle:develop Sep 5, 2023
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants