【complex op】No.25 add complex support for fold #56914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
PTAL @GGBond8488 @ScottWong98 |
ScottWong98
reviewed
Sep 4, 2023
test/legacy_test/test_fold_op.py
Outdated
| ).astype(self.dtype) | ||
|
|
||
| def init_dtype(self): | ||
| pass |
There was a problem hiding this comment.
pass -> self.dtype = np.float64
test/legacy_test/test_fold_op.py
Outdated
| @@ -40,6 +40,14 @@ def init_data(self): | |||
| self.output_sizes = [4, 5] | |||
| input_shape = [self.batch_size, self.input_channels, self.length] | |||
| self.x = np.random.rand(*input_shape).astype(np.float64) | |||
There was a problem hiding this comment.
astype(np.float64) -> astype(self.dtype)
| @@ -75,7 +83,7 @@ def calc_fold(self): | |||
| ) | |||
| + 1 | |||
| ) | |||
| output = np.zeros(output_shape).astype(np.float64) | |||
| output = np.zeros(output_shape).astype(self.dtype) | |||
There was a problem hiding this comment.
建议 init_dtype 中给个 self.dtype 的默认值（np.float64）感觉会好些，不然这块在 TestFold 中 self.dtype = None，虽然最终结果没影响，但感觉有点不统一
luotao1
added
HappyOpenSource Pro
luotao1
approved these changes
Sep 11, 2023
|
@BeingGod 请修改下对应的中文文档 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
add support complex for
fold#56145