Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Complex OP】No.28 LogSigmoid #56852

Merged
merged 3 commits into from
Sep 7, 2023
Merged

【Complex OP】No.28 LogSigmoid #56852

merged 3 commits into from
Sep 7, 2023

Conversation

yangguohao
Copy link
Contributor

@yangguohao yangguohao commented Aug 31, 2023 •
edited by luotao1
Loading

PR types

Others

PR changes

OPs

Description

为 LogSigmoid 添加对 complex64 complex 128 的支持

@paddle-bot
Copy link

paddle-bot bot commented Aug 31, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Aug 31, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Sep 1, 2023
@luotao1 luotao1 mentioned this pull request Sep 1, 2023
Closed
@yangguohao
Copy link
Contributor Author

@ScottWong98 @GGBond8488 @luotao1 我新开了个 PR 修改了之前的问题，麻烦再 review 下

ScottWong98
ScottWong98 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@ScottWong98 ScottWong98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 另 rerun 一下 Coverage 的 CI

luotao1
luotao1 reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image rerun了两次都挂在这儿，我再rerun一次吧

@yangguohao
Copy link
Contributor Author

image rerun了两次都挂在这儿，我再rerun一次吧

这个现在有在跑吗 我这里的 Coverage 一直显示 pending

@luotao1
Copy link
Contributor

luotao1 commented Sep 1, 2023

是的，排队中，应该和你的PR没关系，因为我在另一个PR的coverage流水线中也是一样的错误。

@yangguohao
Copy link
Contributor Author

Coverage 还是挂了，好像是 dot 的复数的精度检测没过，还要再 rerun 一下

@ScottWong98
Copy link
Contributor

Coverage 还是挂了，好像是 dot 的复数的精度检测没过，还要再 rerun 一下

@yangguohao 再重新 run 一下 Coverage CI 吧 :)

@yangguohao
Copy link
Contributor Author

Coverage 还是挂了，好像是 dot 的复数的精度检测没过，还要再 rerun 一下

@yangguohao 再重新 run 一下 Coverage CI 吧 :)

无权操作流水线，要请其他人 rerun 下

@yangguohao
Copy link
Contributor Author

@luotao1 麻烦 coverage 再 rerun 下

@tianshuo78520a
Copy link
Contributor

tianshuo78520a commented Sep 5, 2023 •
edited
Loading

我看失败的任务都是超时取消，编译时会卡住，是否有问题？

@yangguohao
Copy link
Contributor Author

我看失败的任务都是超时取消，编译时会卡住，是否有问题？

之前 CI 都已经过了，我 merge 了 develop 分支导致重跑 CI，不知道是不是有一些 commits 存在问题

@yangguohao
Copy link
Contributor Author

@luotao1 @ScottWong98 @GGBond8488 CI 都过了

@luotao1 luotao1 added HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 and removed HappyOpenSource 快乐开源活动issue与PR labels Sep 6, 2023
ScottWong98
ScottWong98 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@ScottWong98 ScottWong98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PaddlePaddle-Gardener
PaddlePaddle-Gardener approved these changes Sep 7, 2023
View reviewed changes
Copy link

@PaddlePaddle-Gardener PaddlePaddle-Gardener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit f6463ea into PaddlePaddle:develop Sep 7, 2023
@luotao1
Copy link
Contributor

luotao1 commented Sep 7, 2023

@yangguohao 请对应修改下中文文档

@yangguohao
Copy link
Contributor Author

@yangguohao 请对应修改下中文文档

好的

BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
@yangguohao @BeingGod
【Complex OP】No.28 LogSigmoid (PaddlePaddle#56852)
84ac63b 
* complex op logsigmoid

* fix 2023-08-31
@yangguohao yangguohao deleted the complex_LogSigmoid branch September 18, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@ScottWong98 ScottWong98 ScottWong98 approved these changes

@PaddlePaddle-Gardener PaddlePaddle-Gardener PaddlePaddle-Gardener approved these changes

Assignees

@luotao1 luotao1

@GGBond8488 GGBond8488

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yangguohao @luotao1 @ScottWong98 @tianshuo78520a @PaddlePaddle-Gardener @GGBond8488