Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NewIR]support c_allreduce_sum/c_identity/c_embedding/c_embedding_grad #56836

Merged
merged 7 commits into from
Sep 4, 2023

Conversation

zhaoyinglia
Copy link
Contributor

@zhaoyinglia zhaoyinglia commented Aug 31, 2023

PR types

New features

PR changes

OPs

Description

Pcard-67164

  • NewIR support c_allreduce_sum/c_identity/c_embedding/c_embedding_grad for model parallel

@paddle-bot
Copy link

paddle-bot bot commented Aug 31, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented Aug 31, 2023

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@zhaoyinglia zhaoyinglia changed the title [NewIR]support c_allreduce_sum/c_identity/c_reduce_sum/c_embedding/c_embedding_grad [NewIR]support c_allreduce_sum/c_identity/c_embedding/c_embedding_grad Sep 1, 2023
Comment on lines +214 to +218
void CEmbeddingInferMeta(const MetaTensor& weight,
const MetaTensor& x,
int64_t start_index,
MetaTensor* out);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InferMeta函数需要按照字典序放置,方便查找

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will fix it in the next pr.

Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for new c++ ops

Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs,no docs changes

@zyfncg zyfncg merged commit 0e74bf3 into PaddlePaddle:develop Sep 4, 2023
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
PaddlePaddle#56836)

* [NewIR]add c_allreduce_sum/c_identity/c_reduce_sum/c_embedding/c_embedding_grad

* rm VLOG

* rm c_identity from LegacyOpList

* rm VLOG

* rm c_reduce_sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants