Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] change Flatten to Fuse #56719

Conversation

BiynXu
Copy link
Contributor

@BiynXu BiynXu commented Aug 28, 2023

PR types

Bug fixes

PR changes

Others

Description

Pcard-73602
Change FlattenLoops in the elementwise schedule to Fuse

@paddle-bot
Copy link

paddle-bot bot commented Aug 28, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@BiynXu BiynXu force-pushed the change_Flatten_in_the_elementwise_schedule_to_Fuse branch from 1fb1b4d to ed990d3 Compare August 29, 2023 06:04
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for
set_tests_properties(test_group_norm_op PROPERTIES TIMEOUT 1000)

Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Special: this PR increased the timeout of test_group_norm_op.

We doubt it is due to the longer index computation after changing fuse, and we thought the running speed won't be impacted theoretically. So we would like to merge this PR.

@zhhsplendid zhhsplendid merged commit d38cd6c into PaddlePaddle:develop Sep 4, 2023
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
Change FlattenLoops in the elementwise schedule to Fuse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants