Add dimOp, tieProductEqualOp. access constraint_func in SymbolTable. Lowing DenseTensorType. #56615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… assist_struct
liuruyan
changed the title
winter-wang
reviewed
Aug 28, 2023
| @@ -17,15 +17,122 @@ | |||
| #include "paddle/ir/core/type.h" | |||
| #include "paddle/ir/core/type_base.h" | |||
| #include "paddle/ir/core/utils.h" | |||
| #include "paddle/phi/common/layout.h" | |||
There was a problem hiding this comment.
不建议在paddle/ir里面产生对phi的依赖。
There was a problem hiding this comment.
layout.h只是头文件，没有cc文件。在预处理阶段会展开，不会引入phi依赖。关于ddim的处理则是在编译时独立编包，ir_core 独立依赖 ddim。
ir_library(ir_core SRCS ${IR_SRCS})
ir_library(ir_core SRCS ${IR_SRCS} DEPS ddim)
There was a problem hiding this comment.
拆分独立编译 ddim 的 pr 如下：#56351
lxd-cumt
pushed a commit
to lxd-cumt/Paddle
that referenced
this pull request
Aug 28, 2023
…Lowing DenseTensorType. (PaddlePaddle#56615) * add symbolicDimProduct & symbolicDimMgr without method shape_constraint related. * add pd_type.cc to ir_shape CMakeLists. * add dimOp, tieProductEqualOp. access constraint_func in SymbolTable. * put DenseTensorType into builtin_type.
BeingGod
pushed a commit
to BeingGod/Paddle
that referenced
this pull request
Sep 9, 2023
…Lowing DenseTensorType. (PaddlePaddle#56615) * add symbolicDimProduct & symbolicDimMgr without method shape_constraint related. * add pd_type.cc to ir_shape CMakeLists. * add dimOp, tieProductEqualOp. access constraint_func in SymbolTable. * put DenseTensorType into builtin_type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Other
Pcard-67164