[Auto Parallel] Compatible new comm library upgrade #56604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluid operator support new comm library
…uce_scatter and c_scatter.
1. remove useless loggings. 2. Fix conditional compilation for HIP. 3. Fix problems of test_pass_generation_pipeline.py. It calls paddle.distributed.init_parallel_env() at first, then auto.Engine calls _init_comm(), which will calls process_group.instantiate(). However, init_parallel_env() will call paddle.distributed.barrier(), it will call CreateNCCLEnvCache and create corresponding NCCLCommContext. But dev_id is not set, as a result, NCCLCommContext's dev_ctx is not initialized.
… static_compat_upgrade
will be submitted in another PR.
LiYuRio
reviewed
Aug 24, 2023
hitywt
reviewed
Aug 24, 2023
… pure_static_compat_upgrade
… pure_static_compat_upgrade
LiYuRio
previously approved these changes
Aug 25, 2023
zhiqiu
reviewed
Aug 28, 2023
| @@ -67,7 +77,29 @@ void CommContextManager::CreateNCCLCommContext( | |||
|
|
|||
| auto nccl_comm_context = | |||
| std::make_unique<NCCLCommContext>(rank, size, nccl_id); | |||
| auto& comm_context_manager = CommContextManager::GetInstance(); | |||
|
|
|||
| if (CommContextManager::device_id != -1) { | |||
There was a problem hiding this comment.
why not use dev_ctx from global dev_ctx pool?
There was a problem hiding this comment.
NCCLCommContext holds std::unique_ptr<phi::GPUContext> dev_ctx, so we create a new object out of DeviceContextPool control.
… pure_static_compat_upgrade
LiYuRio
approved these changes
Aug 30, 2023
BeingGod
pushed a commit
to BeingGod/Paddle
that referenced
this pull request
Sep 9, 2023
* for verify fluid operator support new comm library * u * u * u * compatiable new comm library upgrade for c_allgather, c_reduce, c_reduce_scatter and c_scatter. * Remove useless comments in process_group.py * Polish code style. * Fix some problems. * Remove use fluid api in phi comm_context_manager. * Add PPADDLE_WITH_CUDA and PADDLE_WITH_NCCL micro judgement. * Fix bug of HIP architecture. * Fix some problems. 1. remove useless loggings. 2. Fix conditional compilation for HIP. 3. Fix problems of test_pass_generation_pipeline.py. It calls paddle.distributed.init_parallel_env() at first, then auto.Engine calls _init_comm(), which will calls process_group.instantiate(). However, init_parallel_env() will call paddle.distributed.barrier(), it will call CreateNCCLEnvCache and create corresponding NCCLCommContext. But dev_id is not set, as a result, NCCLCommContext's dev_ctx is not initialized. * Fix some problems. * Polish code. * Polish code. * Revert compatiable upgrade for communication operators. Their upgrades will be submitted in another PR. * Remove StaticTCPStore. * Remove useless modification. * Remove useless set_cuda_device_id. * Polish code. * Remove fluid header files in phi files. * Remove useless comments. * Fix problems of hip arch. * Fix some problems. * Polish code. * Polish code style. --------- Co-authored-by: hitywt <yuwentao126@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-70448
Upgrade fluid operators to be compatible with new communication library. Old communication library is used defaultly. Switch to new communication library by export
FLAGS_dynamic_static_unified_comm=1. We can use new communication library in default as soon as all communication operators are upgraded compatibly.