Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Semi-Auto] Add reduction infer_backward rule #56504

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

pkuzyc
Copy link
Contributor

@pkuzyc pkuzyc commented Aug 21, 2023

PR types

Function optimization

PR changes

Others

Description

Pcard-70448

Add infer backward SPMD rule for reduction. It infers inputs' dims mappings as following:

For non-reduced axes, set their dims mappings equal to the outputs'. For the reduced axes, set them to -1.

@paddle-bot
Copy link

paddle-bot bot commented Aug 21, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Sep 1, 2023

Sorry to inform you that bdda6f2's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

const paddle::framework::AttributeMap& attrs) override;

private:
std::string GetOutputNotation(int64_t input_ndim,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the class for rule will be remove and fw & bw will be independent functions.
so place this utils another place and as independent function


self.assertEqual(infered_input_dist_attrs[0].dims_mapping, [-1, -1])
self.assertEqual(infered_output_dist_attrs[0].dims_mapping, [-1])

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the partial is false

self.assertEqual(infered_input_dist_attrs[0].dims_mapping, [-1, -1])
self.assertEqual(infered_output_dist_attrs[0].dims_mapping, [-1])

# reduce on dim 0, keep_dim = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add a kind new case that output is partial on curtain dims, and how it influence input :
stage 1: input is not effect
stage2: input should be sharded on that dims

Copy link
Contributor

@JZ-LIANG JZ-LIANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update in Next PR

@JZ-LIANG JZ-LIANG merged commit fa1d0e3 into PaddlePaddle:develop Sep 8, 2023
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
@pkuzyc pkuzyc deleted the reduction_backward branch September 27, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants