Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sm小于80的机器支持trt_flash_multihead_matmul_fuse_pass #56492

Merged
merged 9 commits into from
Sep 15, 2023
Merged

sm小于80的机器支持trt_flash_multihead_matmul_fuse_pass #56492

merged 9 commits into from
Sep 15, 2023

Conversation

yangjianfengo1
Copy link
Contributor

@yangjianfengo1 yangjianfengo1 commented Aug 21, 2023

PR types

Performance optimization

PR changes

Others

Description

Pcard-71501
sm<80的机器使用memory_efficient_attention支持trt_flash_multihead_matmul_fuse_pass,测试数据如下:
image

@paddle-bot
Copy link

paddle-bot bot commented Aug 21, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@yangjianfengo1 yangjianfengo1 changed the title flash attention sm<80的机器使用memory_efficient_attention支持trt_flash_multihead_matmul_fuse_pass Aug 24, 2023
@yangjianfengo1 yangjianfengo1 changed the title sm<80的机器使用memory_efficient_attention支持trt_flash_multihead_matmul_fuse_pass sm小于80的机器支持trt_flash_multihead_matmul_fuse_pass Aug 24, 2023
@@ -32,10 +32,12 @@ def is_program_valid(self, program_config: ProgramConfig) -> bool:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可能需要加一个ut,测试下 q/k/v 输入为两个input(非一个input, 一个weight)的情况

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已加

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Sep 13, 2023

Sorry to inform you that 76d8b4f's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link
Contributor

@yuanlehome yuanlehome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for const_cast

@yuanlehome yuanlehome merged commit 172461d into PaddlePaddle:develop Sep 15, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* jingdu duiqi need check

* code style

* code style

* add weight is input

* code style

* windows ci

* fix weight name

* rerun ci

* re run ci

---------

Co-authored-by: yangjianfengo1 <yangjianfeng01.baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants