Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clang-tidy] NO.62,63 enable clang-analyzer-security.insecureAPI.vfork、clang-analyzer-unix.Vfork #56253

Merged
merged 1 commit into from
Aug 15, 2023
Merged

[clang-tidy] NO.62,63 enable clang-analyzer-security.insecureAPI.vfork、clang-analyzer-unix.Vfork #56253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,13 +137,13 @@ bugprone-unused-raii,
-clang-analyzer-security.insecureAPI.mktemp,
-clang-analyzer-security.insecureAPI.rand,
-clang-analyzer-security.insecureAPI.strcpy,
-clang-analyzer-security.insecureAPI.vfork,
clang-analyzer-security.insecureAPI.vfork,
-clang-analyzer-unix.API,
-clang-analyzer-unix.DynamicMemoryModeling,
-clang-analyzer-unix.Malloc,
-clang-analyzer-unix.MallocSizeof,
-clang-analyzer-unix.MismatchedDeallocator,
-clang-analyzer-unix.Vfork,
clang-analyzer-unix.Vfork,
-clang-analyzer-unix.cstring.BadSizeArg,
-clang-analyzer-unix.cstring.CStringModeling,
-clang-analyzer-unix.cstring.NullArg,
Expand Down
4 changes: 2 additions & 2 deletions paddle/fluid/framework/io/shell.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ static int shell_popen_fork_internal(const char* real_cmd,
int child_pid = -1;
// Too frequent calls to fork() makes openmpi very slow. Use vfork() instead.
// But vfork() is very dangerous. Be careful.
if ((child_pid = vfork()) < 0) {
if ((child_pid = vfork()) < 0) { // NOLINT
return -1;
}

Expand All @@ -127,7 +127,7 @@ static int shell_popen_fork_internal(const char* real_cmd,
return child_pid;
}

int child_std_end = do_read ? 1 : 0;
int child_std_end = do_read ? 1 : 0; // NOLINT
close(parent_end);

if (child_end != child_std_end) {
Expand Down