Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tcp store as a global instance #55956

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

LiYuRio
Copy link
Contributor

@LiYuRio LiYuRio commented Aug 3, 2023

PR types

Others

PR changes

Others

Description

Pcard-70448

因为动半reshard需要获取tcp_store并在第一次通信时创建通信组,所以这个PR将tcp_store的获取改成C++端的单例,而且要保证第一次调用创建tcp_store是在全局通信组下。

@paddle-bot
Copy link

paddle-bot bot commented Aug 3, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@LiYuRio LiYuRio force-pushed the dev_global_store branch 15 times, most recently from 02d213a to b778c0c Compare August 4, 2023 09:48
Copy link
Contributor

@hitywt hitywt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ForFishes ForFishes merged commit 0434b82 into PaddlePaddle:develop Aug 7, 2023
@LiYuRio LiYuRio deleted the dev_global_store branch August 7, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants