Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang-tidy] NO.6 enable modernize-avoid-c-arrays check #55774

Merged
merged 17 commits into from
Aug 2, 2023
Merged

[clang-tidy] NO.6 enable modernize-avoid-c-arrays check #55774

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ed8b952
[clang-tidy] modernize-avoid-c-arrays
gouzil Jul 28, 2023
b2f5cad
rollback
gouzil Jul 29, 2023
dedfecb
[clang-tidy] fix
gouzil Jul 29, 2023
0733b53
close modernize-avoid-c-arrays
gouzil Jul 29, 2023
40d4e4f
fix PHI_DEFINE_string; add PHI_DEFINE_bool NOLINT
gouzil Jul 29, 2023
3451309
fix PHI_DEFINE_string
gouzil Jul 29, 2023
1c06f83
fix next_h_state and parity err
gouzil Jul 29, 2023
c737c0b
fix win32
gouzil Jul 29, 2023
8c5b8a1
fix cuda_graph
gouzil Jul 30, 2023
32546e9
fix accuracy_kernel
gouzil Jul 30, 2023
bb9db5d
fix math_function
gouzil Jul 30, 2023
12a016f
fix fused_softmax_mask_kernel.cu load_data and warp_reduce; rollback …
gouzil Jul 30, 2023
4652fe5
fix fused_dropout_add_grad_kernel
gouzil Jul 30, 2023
582446b
fix
gouzil Jul 31, 2023
da924d1
rollback cu
gouzil Jul 31, 2023
0168cc6
rollback concat_and_split_functor.cu
gouzil Jul 31, 2023
914986c
rollback
gouzil Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions paddle/ir/core/builtin_op.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@

namespace ir {

const char *ModuleOp::attributes_name[attributes_num] = {"program"};

Program *ModuleOp::program() {
const AttributeMap &attr = this->attributes();
auto iter = attr.find("program");
Expand Down Expand Up @@ -67,9 +65,6 @@ void ModuleOp::Verify() const {
IR_ENFORCE(num_results() == 0u, "The size of inputs must be equal to 0.");
}

const char *GetParameterOp::attributes_name[attributes_num] = {
"parameter_name"};

void GetParameterOp::Build(Builder &builder,
OperationArgument &argument,
const std::string &name,
Expand Down
4 changes: 2 additions & 2 deletions paddle/ir/core/builtin_op.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class IR_API ModuleOp : public ir::Op<ModuleOp> {
using Op::Op;
static const char *name() { return "builtin.module"; }
static constexpr uint32_t attributes_num = 1;
static const char *attributes_name[attributes_num];
const std::array<char *, attributes_num> attributes_name = {"program"};
void Verify() const;
Program *program();
Block *block();
Expand All @@ -50,7 +50,7 @@ class IR_API GetParameterOp : public ir::Op<GetParameterOp> {
using Op::Op;
static const char *name() { return "builtin.get_parameter"; }
static constexpr uint32_t attributes_num = 1;
static const char *attributes_name[attributes_num];
const std::array<char *, attributes_num> attributes_name = {"parameter_name"};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里我们是必须要设定为 static，不建议修改

static void Build(Builder &builder, // NOLINT
OperationArgument &argument, // NOLINT
const std::string &name,
Expand Down
2 changes: 1 addition & 1 deletion paddle/utils/string/pretty_log.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

#include "gflags/gflags.h"

DEFINE_bool(color, true, "Whether to turn on pretty log");
DEFINE_bool(color, true, "Whether to turn on pretty log"); // NOLINT

namespace paddle {
namespace string {} // namespace string
Expand Down