[Reshard] Implement replicated to split with same placement #55552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
LiYuRio
changed the title
LiYuRio
force-pushed
the
dev_reshard
branch
8 times, most recently
from
d2ad29f
to
ae6fc4b
Compare
LiYuRio
force-pushed
the
dev_reshard
branch
2 times, most recently
from
bc01ab6
to
fd19cbb
Compare
chenwhql
reviewed
Jul 20, 2023
| ReshardFunction() = default; | ||
| virtual ~ReshardFunction() = default; | ||
|
|
||
| virtual bool Check(const DistTensor& in, |
There was a problem hiding this comment.
细节问题，这个接口语义可以再具体一些吗？尽量让代码可以自解释一些，比如这里是check什么？Check是否Valid吗
There was a problem hiding this comment.
改成了IsSuitable，检查当前状态转换函数是否适合，
paddle/phi/core/distributed/auto_parallel/reshard_split_functor.h
Outdated
Show resolved
Hide resolved
paddle/phi/core/distributed/auto_parallel/reshard_split_functor.cc
Outdated
Show resolved
Hide resolved
LiYuRio
force-pushed
the
dev_reshard
branch
4 times, most recently
from
55bb8b6
to
1a4debb
Compare
LiYuRio
force-pushed
the
dev_reshard
branch
2 times, most recently
from
ae347a6
to
6c53507
Compare
ForFishes
reviewed
Jul 25, 2023
| virtual bool Check(const DistTensor& in, | ||
| const std::shared_ptr<TensorDistAttr>& out_dist_attr) = 0; | ||
|
|
||
| virtual std::shared_ptr<DistTensor> Eval( |
wz1qqx
pushed a commit
to wz1qqx/Paddle
that referenced
this pull request
Jul 31, 2023
…ddle#55552) * Implement replicated to split reshard function * fix link error in clang * refine split functor * simplify reshard code
jinjidejinmuyan
pushed a commit
to jinjidejinmuyan/Paddle
that referenced
this pull request
Aug 30, 2023
…ddle#55552) * Implement replicated to split reshard function * fix link error in clang * refine split functor * simplify reshard code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
Pcard-73145
支持Replicated到Shard的状态转换，要求：
以4卡为例，输入输出都是一维process_mesh，[0, 1, 2, 3]，输入为二维Replicated状态，in_tensor_shape = [4, 8]，in_dims_mapping = [-1, -1]，输出为二维Shard状态。