-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpCompat] add assert in op_compat.yaml #55500
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
paddle/phi/api/yaml/op_compat.yaml
Outdated
@@ -266,6 +266,12 @@ | |||
extra : | |||
attrs : [bool use_mkldnn = false, bool use_cudnn = false] | |||
|
|||
- op : assert | |||
inputs : | |||
{cond : kCond, data : kData} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以再看下 paddle/fluid/operators/assert_op.cc
,这里的kCond和kData是变量,实际不是这个字符串。下同
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的已修改
paddle/phi/api/yaml/op_compat.yaml
Outdated
- op : assert | ||
inputs : | ||
{cond : Cond, data : Data} | ||
# attrs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注释还是删掉吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的已删除
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add assert * fix * fix
* add assert * fix * fix
* add assert * fix * fix
PR types
Others
PR changes
Others
Description
add assert in op_compat.yaml