add sin and cos optional parameters to fused_rope op #55415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
tianhaodongbd
changed the title
tianhaodongbd
changed the title
test/legacy_test/_run.log
Outdated
| @@ -0,0 +1,2 @@ | |||
| timeout: invalid option -- '1' | |||
| Try 'timeout --help' for more information. | |||
| @@ -124,6 +124,68 @@ def get_forward_backward(self, rope_function, seed): | |||
|
|
|||
| return fw, bw | |||
|
|
|||
| def get_forward_backward_sin_cos(self, rope_function, seed): | |||
There was a problem hiding this comment.
和上面的重复代码有点多， 可以把共用的抽出来
Xreki
reviewed
Jul 20, 2023
|
|
||
| for (; index < size; index += stride) { | ||
| #pragma unroll | ||
| for (int nx = 0; nx < VecSize; ++nx) { |
There was a problem hiding this comment.
VectorizedFusedRopeWithSinCosKernel和VectorizedFusedRopeKernel只有L46-L56、L108-L117的实现不同，其他代码都一样，没有必要定义成两个函数，代码尽量复用一下。- sin、cos计算的逻辑，算子前、反向也是一样的，可以挪到头文件中以复用
…& move VectorizedFusedRopeKernel to fused_rope_utils.h
qingqing01
approved these changes
Jul 26, 2023
sunzhongkai588
approved these changes
Jul 26, 2023
wz1qqx
pushed a commit
to wz1qqx/Paddle
that referenced
this pull request
Jul 31, 2023
jinjidejinmuyan
pushed a commit
to jinjidejinmuyan/Paddle
that referenced
this pull request
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-70458
fused_rope算子功能加强，支持传入optional的sin、cos输入