[Semi Auto] Softmax SPMD Rule #55196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… semi-auto/rule-base
|
你的PR提交成功，感谢你对开源项目的贡献! |
…i-auto/embedding-rule
zhiqiu
reviewed
Jul 11, 2023
| weight_ndim, | ||
| weight_dims_mapping.size(), | ||
| phi::errors::InvalidArgument( | ||
| "Mismatch of Y's tensor size: [%d] and Y's dims_mapping size [%d].", |
Comment on lines
71
to
72
| // padding_idx s not supported by c_embedding kernl. | ||
| // (TODO) might be could reshard as replicated when padding_idx != -1 |
There was a problem hiding this comment.
the implement of c_embedding kernel require the padding item is in the of table, which means "padding_idx = -1" and not allow being set by user.
to support vocab parallel of embedding op efficiently, we need to use c_embedding kernel, therefore, we make a precondition check that "padding_idx = -1" when embedding table is sharded by vocab axis.
zhiqiu
reviewed
Jul 11, 2023
| << str_join(out_dims_mapping) << "], partial_on_dims: [" | ||
| << str_join(partial_on_dims) << "]"; | ||
|
|
||
| return {{x_dist_attr_src, weight_dist_attr_src}, {output_dist_attr_dst}}; |
cqulilujia
pushed a commit
to cqulilujia/Paddle
that referenced
this pull request
Jul 24, 2023
* resolute input sharding conflict maybe * fixed comment --------- Co-authored-by: Yichen Zhang <zhangyichen03@baidu.com> Co-authored-by: zhiqiu <chenqiuliang@baidu.com>
wz1qqx
pushed a commit
to wz1qqx/Paddle
that referenced
this pull request
Jul 31, 2023
* resolute input sharding conflict maybe * fixed comment --------- Co-authored-by: Yichen Zhang <zhangyichen03@baidu.com> Co-authored-by: zhiqiu <chenqiuliang@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Description
Pcard-70448
SPMD rule for softmax like ops (softmax, log_softmax).
sharding on normlized axis will be support in future.