【CINN】refactor ir_visitor #55171
Merged
【CINN】refactor ir_visitor #55171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhhsplendid
reviewed
Jul 7, 2023
paddle/cinn/optim/ir_copy.cc
Outdated
| return op__::Make(v); \ | ||
| #define OP_UNARY_HANDLE(op__) \ | ||
| Expr Visit(const op__* op) override { \ | ||
| auto v = IRVisitorRequireReImplVisitor::Visit(&op->v()); \ |
There was a problem hiding this comment.
Why are 2 Visitors in name?
Using IrVisitorRequireReImplor IrRequireReImplVisitor?
paddle/cinn/pybind/ir.cc
Outdated
There was a problem hiding this comment.
Why is there an empty file? Should we delete it?
cqulilujia
pushed a commit
to cqulilujia/Paddle
that referenced
this pull request
Jul 24, 2023
This PR delete middle ir_visitor class and thus we can avoid middle virtual function call and codes look more clean pcard-72718
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
Others
Description
This PR delete middle ir_visitor class and thus we can avoid middle virtual function call and codes look more clean
pcard-72718