Support stride #55156

wanghuancoder · 2023-07-05T06:27:55Z

PR types

New features

PR changes

Others

Description

Pcard-71699

添加Stride机制，主要工作包括：

DenseTensor支持Stride数据结构
Stride的初始化
添加新的layout：STRIDED，当框架存在STRIDED kernel时，优先使用STRIDED kernel
支持连续Tensor和非连续Tensor的互转（contiguous、strided_copy）
新动态图（包括中间态），支持stride op和非stride op的混合使用
支持非连续Tensor的inplace操作

目前stride策略默认关闭，待测试稳定后设为默认打开。开关为：FLAGS_use_stride_kernel

FLAGS_use_stride_kernel为1时如下API将支持stride：slice, strided_slice, index_select, split, chunk, unbind, as_real, detach, transpose, t, moveaxis, moveaxis, moveaxis, T, reshape, squeeze, unsqueeze, squeeze_, unsqueeze_, flatten, diagonal, imag, real
此外动态图下新增了如下API：view, view_as, as_strided, unfold, contiguous, is_contiguous, detach_, Tensor.data, Tensor.grad(赋值操作）

目前只有动态图支持stride，静态图尚不支持。这可能会发生动静不一致的情况。如果动转静时发生动静不一致，框架将报错处理。

… support_stride

… support_stride2

Aurelius84

LGTM

Aurelius84 · 2023-07-26T06:05:05Z

paddle/phi/api/lib/api_gen_utils.cc

+      backup.emplace_back(nullptr);
+    } else {
+      backup.emplace_back(t);
+      t = new phi::DenseTensor();


这里new出来的对象，在哪里做的delete？

这个计划在TransStride里做的，忘记了。我给加上了感谢！

Aurelius84 · 2023-07-26T06:08:46Z

paddle/phi/api/yaml/generator/api_base.py

+            "squeeze",
+            "unsqueeze",
+            "reshape",
+            "flatten",


后续这个名单是否会考虑类似文件前面的PREFIX_TENSOR_NAME 一样的全局变量标记一下？

这个名单的意思是，这4个C++ API，本身已经支持stride。不需要再通过ProcessStrideBackup和TransStride来特殊处理inplace了。暂时没有再修改的计划。

Aurelius84 · 2023-07-26T06:10:50Z

paddle/phi/core/ddim.h

@@ -210,6 +217,9 @@ DDim make_ddim(std::initializer_list<int64_t> dims);

 template <typename T = int64_t>
 std::vector<T> vectorize(const DDim& ddim) {
+  if (ddim.size() == -1) {
+    return std::vector<T>({0});


若 shape = [0] 是否意味着其 ddim.size() == -1 ？这里是特殊标记了一下？

-1是我新引入的，表示ddim还没有初始化。
shape=[0]的意思是已经初始化过了size()==1~

XiaoguangHu01

LGTM

XieYunshen

LGTM
单测超时时间设置

zyfncg · 2023-07-28T09:22:00Z

paddle/phi/core/meta_tensor.cc

+    if (!strided_kernel_used_) {
+      meta->strides = meta->calc_strides(dims);
+    }


这里是非strided_kernel时才需要计算stride信息吗？感觉有些和直觉相反

是的，stride kernel会在真正kernel里计算

zyfncg · 2023-07-28T09:23:11Z

paddle/phi/core/meta_tensor.cc

+    if (!strided_kernel_used_) {
+      meta->strides = meta->calc_strides(meta->dims);
+    }


set_layout和set_dims各处理一次stride是重复计算吗？

layout和dims发生改变时，需要重新计算stride。所以两个都加了

zyfncg · 2023-07-28T09:25:31Z

paddle/phi/infermeta/unary.cc

@@ -18,6 +18,7 @@ limitations under the License. */
 #include <set>

 #include "gflags/gflags.h"
+#include "paddle/fluid/platform/flags.h"


phi独立编译后不能再使用fluid的头文件了

好的，感谢。改成使用#include "paddle/phi/core/flags.h"了

Aurelius84

LGTM

XiaoguangHu01

LGTM

sunzhongkai588

LGTM
有以下几点文档的问题，之后提pr优化叭～

contiguous, is_contiguous, detach_, Tensor.data, Tensor.grad(赋值操作） 这几个api文档没找着，是没暴露嘛？
请补充一下API相应的中文文档

wanghuancoder added 30 commits March 31, 2023 02:39

add tensor meta

4442a43

first finish

3b1d1ae

test_stride run ok

1f4c45f

refine

3487d4b

refine

60db80a

refine

31c5aef

refine

5d76acd

calc_strides

6281288

refine resize

ec6bc34

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

c023dd9

… support_stride

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

3ce042a

… support_stride

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

c2ff644

… support_stride

refine

fa535d7

refine

dcbe813

refine stride init, refine contiguous, add strided_copy

eeafe5c

refine

2f96ef3

refine

57d3fae

strided copy xpu

86b4184

stride init layout

4b5c0aa

refine

4f46348

refine

8ebe1ee

do not call TransposeStrideKernel in Transpose

68f0e34

refine

94b851f

inplace

e7d4d20

refine

71e96c8

refine

d0a5e69

refine

f6f1b41

refine inplace

4990b8d

refine a lot

65132db

refine

2f98a27

wanghuancoder added 5 commits July 20, 2023 07:10

merge

3360ffc

refine

0956b0c

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

81ccd70

… support_stride2

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

39c8086

… support_stride2

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

2d85bc9

… support_stride2

Aurelius84 previously approved these changes Jul 26, 2023

View reviewed changes

fix no delete bug

e76977a

wanghuancoder dismissed Aurelius84’s stale review via e76977a July 27, 2023 02:43

phlrain previously approved these changes Jul 28, 2023

View reviewed changes

XiaoguangHu01 previously approved these changes Jul 28, 2023

View reviewed changes

XieYunshen previously approved these changes Jul 28, 2023

View reviewed changes

zyfncg reviewed Jul 28, 2023

View reviewed changes

refine

6198828

wanghuancoder dismissed stale reviews from XieYunshen, XiaoguangHu01, and phlrain via 6198828 July 28, 2023 09:35

Aurelius84 approved these changes Jul 31, 2023

View reviewed changes

zyfncg approved these changes Jul 31, 2023

View reviewed changes

XieYunshen approved these changes Jul 31, 2023

View reviewed changes

XiaoguangHu01 approved these changes Jul 31, 2023

View reviewed changes

qingqing01 approved these changes Jul 31, 2023

View reviewed changes

sunzhongkai588 approved these changes Jul 31, 2023

View reviewed changes

phlrain self-requested a review July 31, 2023 03:52

phlrain approved these changes Jul 31, 2023

View reviewed changes

tianshuo78520a approved these changes Jul 31, 2023

View reviewed changes

lanxianghit approved these changes Jul 31, 2023

View reviewed changes

wanghuancoder merged commit 859fc01 into PaddlePaddle:develop Jul 31, 2023

wanghuancoder changed the title ~~Support stride2~~ Support stride Aug 14, 2023

This was referenced Mar 5, 2024

[CustomDevice] Support stride kernels #62408

Closed

[NPU] support stride, part 1(slice kernel) PaddlePaddle/PaddleCustomDevice#985

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support stride #55156

Support stride #55156

wanghuancoder commented Jul 5, 2023 •

edited

Loading

Aurelius84 left a comment

Aurelius84 Jul 26, 2023

wanghuancoder Jul 27, 2023

Aurelius84 Jul 26, 2023

wanghuancoder Jul 27, 2023

Aurelius84 Jul 26, 2023

wanghuancoder Jul 27, 2023

XiaoguangHu01 left a comment

XieYunshen left a comment

zyfncg Jul 28, 2023

wanghuancoder Jul 28, 2023

zyfncg Jul 28, 2023

wanghuancoder Jul 28, 2023

zyfncg Jul 28, 2023

wanghuancoder Jul 28, 2023

Aurelius84 left a comment

XiaoguangHu01 left a comment

sunzhongkai588 left a comment •

edited

Loading

Support stride #55156

Support stride #55156

Conversation

wanghuancoder commented Jul 5, 2023 • edited Loading

PR types

PR changes

Description

Aurelius84 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

XiaoguangHu01 left a comment

Choose a reason for hiding this comment

XieYunshen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Aurelius84 left a comment

Choose a reason for hiding this comment

XiaoguangHu01 left a comment

Choose a reason for hiding this comment

sunzhongkai588 left a comment • edited Loading

Choose a reason for hiding this comment

wanghuancoder commented Jul 5, 2023 •

edited

Loading

sunzhongkai588 left a comment •

edited

Loading