-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build error on rocm4.5/rocm5 on ubuntu18.04 #55076
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
❌ The PR is not created using PR's template. You can refer to this Demo. |
Codestyle-Check中检测出的问题,都是原有代码中的code,这个pr的修改根本没有涉及到这些部分 |
Copy from https://github.com/skarupke/flat_hash_map Paddle/.pre-commit-config.yaml Lines 102 to 105 in 485c515
@onepick 辛苦一起修复下 |
没有问题,第三方库可以 exclude 如果有多个 Linter 都报错需要放在 Paddle/.pre-commit-config.yaml Lines 1 to 9 in 485c515
如果只有 cpplint 报错,可只在 cpplint 处 exclude,注意增加注释说明是第三方库即可 |
* declear new rccl api in paddle/fluid * Fix build error:free(): invalid pointer by pick the fix: skarupke/flat_hash_map#26 * Filter to check codestyle for flash_hash_map.h Signed-off-by: jiajuku <jiajuku12@163.com>
Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hi, @onepick
|
PR types
Bug fixes
PR changes
Others
Description