[IR&Pass] Add DCE Pass for new ir. #54935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
yuanlehome
reviewed
Jun 28, 2023
| @@ -40,6 +40,7 @@ endif() | |||
| add_subdirectory(core) | |||
| add_subdirectory(pass) | |||
| add_subdirectory(pattern_rewrite) | |||
| add_subdirectory(transforms) | |||
There was a problem hiding this comment.
transforms目录下再细分为各方向pass目录？
paddle/ir/transforms/CMakeLists.txt
Outdated
| file(GLOB PATTERN_SRCS "*.cc") | ||
|
|
||
| ir_library(ir_builtin_transforms SRCS ${PATTERN_SRCS} DEPS ir_core | ||
| ir_pattern_rewrite) |
winter-wang
reviewed
Jun 28, 2023
| namespace ir { | ||
| class Pass; | ||
|
|
||
| IR_API std::unique_ptr<Pass> CreateDCEPass(); |
There was a problem hiding this comment.
这种是不是命名为CreateDcePass更合适啊？
见google style命名约定
|
DCE pass的单测单独开个文件夹文件？之后加的每个pass不能都放这一个里... |
嗯，公用Pass单独放，单测（构造起来挺麻烦的）单独放 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-71500
Add a naive implementation DCE Pass just for ResNet50 model test.