add gc for multi jobs #54897
Merged
add gc for multi jobs #54897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
added 2 commits
June 27, 2023 11:40
From00
reviewed
Jun 27, 2023
Comment on lines
63
to
65
| std::set<std::string> skip_vars = job->SkipGcVars(); | ||
| execution_config.skip_gc_vars = | ||
| std::set<std::string>(skip_vars.begin(), skip_vars.end()); |
There was a problem hiding this comment.
Suggested change
| std::set<std::string> skip_vars = job->SkipGcVars(); | |
| execution_config.skip_gc_vars = | |
| std::set<std::string>(skip_vars.begin(), skip_vars.end()); | |
| execution_config.skip_gc_vars = job->SkipGcVars(); |
| @@ -59,11 +59,10 @@ StandaloneExecutor::StandaloneExecutor(const platform::Place& place, | |||
|
|
|||
| interpreter::ExecutionConfig execution_config; | |||
| execution_config.create_local_scope = false; | |||
| // TODO(Ruibiao): hack skip gc all vars for multiple jobs, improve it later | |||
| if (jobs.size() > 1) { | |||
| op_info = OpInOutInfo(op) | ||
| op_info.build_op_info() | ||
|
|
||
| for in_name in op.input_arg_names: |
There was a problem hiding this comment.
除了输入var，输出var也应该被处理。
建议在step1中直接预处理每个program的{input_arg_names} + {output_arg_names} - {no_needed_names}集合作为vars_list供step2和step3使用。
From00
reviewed
Jun 27, 2023
Comment on lines
+221
to
+235
| for op in program.global_block().ops: | ||
| op_info = OpInOutInfo() | ||
| for in_name in op.input_arg_names: | ||
| if not var_can_be_deleted(in_name, program): | ||
| continue | ||
|
|
||
| if not op_info.is_build: | ||
| op_info.build_info(op) | ||
|
|
||
| if op_info.is_needed(in_name): | ||
| vars_list[ip].add(in_name) | ||
|
|
||
| for out_name in op.output_arg_names: | ||
| if var_can_be_deleted(out_name, program): | ||
| vars_list[ip].add(out_name) |
There was a problem hiding this comment.
Suggested change
| for op in program.global_block().ops: | |
| op_info = OpInOutInfo() | |
| for in_name in op.input_arg_names: | |
| if not var_can_be_deleted(in_name, program): | |
| continue | |
| if not op_info.is_build: | |
| op_info.build_info(op) | |
| if op_info.is_needed(in_name): | |
| vars_list[ip].add(in_name) | |
| for out_name in op.output_arg_names: | |
| if var_can_be_deleted(out_name, program): | |
| vars_list[ip].add(out_name) | |
| for op in program.global_block().ops: | |
| op_info = OpInOutInfo() | |
| op_info.build_info(op) | |
| for var_name in op.input_arg_names + op.output_arg_names : | |
| if op_info.is_needed(var_name) and var_can_be_deleted(var_name, program): | |
| vars_list[ip].add(var_name) |
From00
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
PCard-71568