Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace the CosineDecay in fluid with 2.0 version #54829

Merged
merged 2 commits into from
Jun 27, 2023
Merged

replace the CosineDecay in fluid with 2.0 version #54829

merged 2 commits into from
Jun 27, 2023

Conversation

longranger2
Copy link
Contributor

PR types

Others

PR changes

APIs

Description

  • remove the CosineDecay in python/paddle/fluid/dygraph/learning_rate_scheduler.py and use CosineDecay in python/paddle/optimizer/lr.py to replace it.

@paddle-bot
Copy link

paddle-bot bot commented Jun 24, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 24, 2023
zoooo0820
zoooo0820 approved these changes Jun 25, 2023
View reviewed changes
Copy link
Contributor

@zoooo0820 zoooo0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jeff41404
jeff41404 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sunzhongkai588
sunzhongkai588 approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no doc's changes. LGTM

@jeff41404 jeff41404 merged commit 5a80483 into PaddlePaddle:develop Jun 27, 2023
@longranger2 longranger2 deleted the CosineDecay branch July 8, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff41404 jeff41404 jeff41404 approved these changes

@zoooo0820 zoooo0820 zoooo0820 approved these changes

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@longranger2 @jeff41404 @zoooo0820 @sunzhongkai588