Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] add xpu and paddle2onnx third_party cache #54451

Merged
merged 16 commits into from
Aug 8, 2023
Merged

[cmake] add xpu and paddle2onnx third_party cache #54451

merged 16 commits into from
Aug 8, 2023

Conversation

DrRyanHuang
Copy link
Member

PR types

Others

PR changes

Others

Description

添加 xpu 和 paddle2onnx 库缓存

@paddle-bot
Copy link

paddle-bot bot commented Jun 8, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 8, 2023
DrRyanHuang

This comment was marked as off-topic.

Sign in to view

@luotao1 luotao1 mentioned this pull request Jun 8, 2023
Closed
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 8, 2023
risemeup1
risemeup1 previously approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@risemeup1 risemeup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@risemeup1
Copy link
Contributor

https://github.com/PaddlePaddle/Paddle/blob/533e31c73f6b50623b2b9e81032592af0f111a9e/cmake/external/xpu.cmake#L135-L140

打扰了，xpu部分这里应该不需要改路径吧

为什么？xpu也应该在需要的时候下载到Paddle/third_party下，可以参考下其他同学PR

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Jun 17, 2023

Sorry to inform you that 939827d's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Jun 26, 2023

Sorry to inform you that 6b5019d's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Jul 12, 2023

Sorry to inform you that 5869ea8's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@luotao1
Copy link
Contributor

luotao1 commented Jul 14, 2023

@DrRyanHuang 可以merge下develop

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Jul 27, 2023

Sorry to inform you that d017244's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@DrRyanHuang
Copy link
Member Author

@gouzil 打扰了，麻烦review一下

@gouzil
Copy link
Member

gouzil commented Aug 8, 2023

@gouzil 打扰了，麻烦review一下

我没权限呀，@risemeup1

risemeup1
risemeup1 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@risemeup1 risemeup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@risemeup1 risemeup1 merged commit 0a1d8c6 into PaddlePaddle:develop Aug 8, 2023
@DrRyanHuang DrRyanHuang deleted the 0605 branch August 8, 2023 05:18
@gouzil gouzil mentioned this pull request Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gouzil gouzil gouzil left review comments

@risemeup1 risemeup1 risemeup1 approved these changes

Assignees

@luotao1 luotao1

@risemeup1 risemeup1

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DrRyanHuang @risemeup1 @luotao1 @gouzil