-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IR] IR attribute printer and support mutable attribute #54369
[IR] IR attribute printer and support mutable attribute #54369
Conversation
…tor_type_support_for_program_translator
…pport_translating_op_attribute
…_translating_op_attribute
…_translating_op_attribute
…_translating_op_attribute
…_translating_op_attribute
…_translating_op_attribute
… refactor_scalar_attribute
… into ir_attribute_printer
你的PR提交成功,感谢你对开源项目的贡献! |
ecfa280
to
ed21d27
Compare
paddle/ir/core/dialect.h
Outdated
@@ -130,8 +132,12 @@ class Dialect { | |||
return *interface; | |||
} | |||
|
|||
virtual void PrintType(ir::Type type, std::ostream &os) { | |||
throw std::logic_error("dialect has no registered type printing hook"); | |||
virtual void PrintType(ir::Type type, std::ostream &os) const { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同在ir命名空间下,就没有显示描述ir::了吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,这里我改一下
paddle/ir/core/ir_printer.cc
Outdated
|
||
protected: | ||
if (auto s = attr.dyn_cast<ir::StrAttribute>()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
类似,同命名空间没必要写ir::
4eaffd8
to
d731403
Compare
PR types
New features
PR changes
Others
Description
Current printer result is like:
Others
Pcard-67164