Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

third-party lib offline compilation support for mkldnn flashattn gtest #54319

Merged
merged 3 commits into from
Jun 5, 2023
Merged

third-party lib offline compilation support for mkldnn flashattn gtest #54319

merged 3 commits into from
Jun 5, 2023

Conversation

GreatV
Copy link
Contributor

@GreatV GreatV commented Jun 3, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

third-party lib offline compilation support for mkldnn flashattn and gtest.

@paddle-bot
Copy link

paddle-bot bot commented Jun 3, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 3, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 3, 2023
risemeup1
risemeup1 approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@risemeup1 risemeup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.gitmodules Show resolved Hide resolved
risemeup1
risemeup1 reviewed Jun 5, 2023
View reviewed changes
Copy link
Contributor

@risemeup1 risemeup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这三个第三方库的tag，你是直接在子模块git checkout过来了然后在根目录提交的吗？确保版本检查没有问题吧

@GreatV
Copy link
Contributor Author

GreatV commented Jun 5, 2023 •
edited
Loading

这三个第三方库的tag，你是直接在子模块git checkout过来了然后在根目录提交的吗？确保版本检查没有问题吧

是的

@luotao1 luotao1 merged commit 20a9d2f into PaddlePaddle:develop Jun 5, 2023
@luotao1 luotao1 mentioned this pull request Jun 5, 2023
Closed
@GreatV GreatV deleted the add_submoudle branch June 11, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risemeup1 risemeup1 risemeup1 approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

Assignees

@luotao1 luotao1

@risemeup1 risemeup1

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GreatV @YuanRisheng @risemeup1 @luotao1