Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CINN] Enable CINN unittest on atan2, tile, top_k, where #54280

Merged
merged 16 commits into from
Jun 13, 2023
Merged

[CINN] Enable CINN unittest on atan2, tile, top_k, where #54280

merged 16 commits into from
Jun 13, 2023

Conversation

FisherWY
Copy link
Contributor

@FisherWY FisherWY commented Jun 1, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

card-71700

为以下算子开启CINN单测：atan2, pool2d, take_along_axis, tile, top_k, where

@paddle-bot
Copy link

paddle-bot bot commented Jun 1, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 1, 2023
@FisherWY FisherWY closed this Jun 9, 2023
@paddle-bot
Copy link

paddle-bot bot commented Jun 9, 2023

很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@FisherWY FisherWY reopened this Jun 9, 2023
thisjiang
thisjiang reviewed Jun 9, 2023
View reviewed changes
test/legacy_test/CMakeLists.txt Outdated Show resolved Hide resolved
test/legacy_test/test_tile_op.py Outdated Show resolved Hide resolved
thisjiang
thisjiang approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@thisjiang thisjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lanxianghit
lanxianghit approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisjiang thisjiang merged commit cf7cd24 into PaddlePaddle:develop Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisjiang thisjiang thisjiang approved these changes

@lanxianghit lanxianghit lanxianghit approved these changes

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FisherWY @thisjiang @lanxianghit