Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XPU][PHI Kernels] bind bitwise_add kernel & add int32/int64 support to scatter_nd_add kernel for xpu #54066

Merged
merged 3 commits into from
May 24, 2023

Conversation

lj970926
Copy link
Contributor

@lj970926 lj970926 commented May 23, 2023

PR types

New features

PR changes

OPs

Description

  1. 添加bitwise_and/bool kernel。由于目前xpu api不支持bitwise操作,目前通过转调logical_and kernel实现(对bool类型logical与bitwise操作是等价的)。
  2. 修复了bitwise_op xpu单测强制指定int32类型导致不能覆盖其他类型的问题。
  3. 为scatter_nd_add kernel添加int32/int64支持。index.numel == 0时原本使用的xpu::add不支持int类型,参考elementwise_add kernel的实现改为调用xpu::broadcast_add。

@paddle-bot
Copy link

paddle-bot bot commented May 23, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels May 23, 2023
@paddle-bot
Copy link

paddle-bot bot commented May 23, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@lj970926 lj970926 changed the title Bind xpu kernels [XPU][PHI Kernels] bind bitwise_add kernel & add int32/int64 support to scatter_nd_add kernel for xpu May 24, 2023
@houj04 houj04 merged commit 0a06140 into PaddlePaddle:develop May 24, 2023
@paddle-bot
Copy link

paddle-bot bot commented May 24, 2023

你的PR已合入Paddle库,请关注后续测试结果。
Your PR has been merged into the repository. An official integration test will be conducted later. Stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants