[NewIR] Printer for Program/Operation/Type and Register ops for ResNet50 #53988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into program_desc_converter
… into program_desc_converter
… into program_desc_converte_to_ir_program
…_desc_converte_to_ir_program
…_desc_converte_to_ir_program
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
zhangbo9674
reviewed
May 22, 2023
| REIGSTER_EMPTY_OP(conv2d, Conv2DOp); | ||
| REIGSTER_EMPTY_OP(feed, FeedOp); | ||
| REIGSTER_EMPTY_OP(batch_norm, BatchNormOp); | ||
| REIGSTER_EMPTY_OP(batch_norm_, BatchNormOp_); |
There was a problem hiding this comment.
BatchNormOp_ 是不是写成 BatchNorm_Op 更合理一些？
There was a problem hiding this comment.
可以的，之后再改。
Sure, will change later.
|
|
||
| namespace ir { | ||
|
|
||
| namespace { |
There was a problem hiding this comment.
这是用来让newline只在printer.cc里可见的，避免该变量暴露在ir命名空间中。
This is used to make newline only visible in printer.cc and avoid it exposed to ir namespace.
zhangbo9674
approved these changes
May 22, 2023
bukejiyu
pushed a commit
to bukejiyu/Paddle
that referenced
this pull request
May 22, 2023
…t50 (PaddlePaddle#53988) * add conv2d * printer draft * fix bug * printer draft finish * fix windows CI * commit printer and resnet50 related ops * fix * fix * fix op definition --------- Co-authored-by: umiswing <umiswing@foxmail.com> Co-authored-by: zhangbo9674 <zhangbo54@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
This PR does the following things:
Others
Pcard-67164