Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update_c++14_to_c++17_on_windows #53958

Merged
merged 3 commits into from
May 22, 2023
Merged

update_c++14_to_c++17_on_windows #53958

merged 3 commits into from
May 22, 2023

Conversation

risemeup1
Copy link
Contributor

@risemeup1 risemeup1 commented May 18, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

Pcard-67010

  • update c++ standard from 14 to 17 on windows, std::binary_function and std::unary function are removed in c++17
  • (to do) update c++ standard from 14 to 17 on linux and mac,there are still some unit tests failures and compile failures to be fixed

@paddle-bot
Copy link

paddle-bot bot commented May 18, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented May 18, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

XieYunshen
XieYunshen approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
单测禁用

zhangbo9674
zhangbo9674 approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@risemeup1 risemeup1 merged commit 6e04320 into PaddlePaddle:develop May 22, 2023
bukejiyu pushed a commit to bukejiyu/Paddle that referenced this pull request May 22, 2023
@risemeup1 @bukejiyu
update_c++14_to_c++17_on_windows (PaddlePaddle#53958)
1c52281 
* update_c++14_to_c++17_on_windows

* disable test_audio_logmel_feature and test_audio_mel_feature
This was referenced May 26, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XieYunshen XieYunshen XieYunshen approved these changes

@zhangbo9674 zhangbo9674 zhangbo9674 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@risemeup1 @XieYunshen @zhangbo9674