Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Zero-Dim] support matmul/ReshapeTransform/nll_loss to support 0D #53828

Merged
merged 1 commit into from
May 25, 2023
Merged

[Zero-Dim] support matmul/ReshapeTransform/nll_loss to support 0D #53828

merged 1 commit into from
May 25, 2023

Conversation

zhwesky2010
Copy link
Contributor

@zhwesky2010 zhwesky2010 commented May 15, 2023 •
edited
Loading

PR types

New features

PR changes

APIs

Description

Pcard-66984

修复以下3种case输出0D：

1. paddle.distribution.ReshapeTransform的_forward_log_det_jacobian类函数
2. paddle.nn.functional.nll_loss在reduce为sum或mean时
3. paddle.matmul在输入x, y均为1D Tensor时，为向量点积(标量积)，应输出0D Tensor表示标量

@paddle-bot
Copy link

paddle-bot bot commented May 15, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented May 15, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@zhwesky2010 zhwesky2010 force-pushed the nll_0d branch 4 times, most recently from d0e647f to cd64d21 Compare May 22, 2023 11:06
@zhwesky2010 zhwesky2010 changed the title [Zero-Dim] support ReshapeTransform/nll_loss to support 0D [Zero-Dim] support ReshapeTransform/nll_loss/matmul to support 0D May 23, 2023
@zhwesky2010 zhwesky2010 changed the title [Zero-Dim] support ReshapeTransform/nll_loss/matmul to support 0D [Zero-Dim] support matmul/ReshapeTransform/nll_loss to support 0D May 23, 2023
@zhwesky2010 zhwesky2010 force-pushed the nll_0d branch 4 times, most recently from af21c5d to c5c8db6 Compare May 23, 2023 14:49
@zhwesky2010 zhwesky2010 mentioned this pull request May 24, 2023
Merged
jeff41404
jeff41404 approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jzhang533
jzhang533 approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit a64a722 into PaddlePaddle:develop May 25, 2023
@zhwesky2010 zhwesky2010 mentioned this pull request May 25, 2023
Closed
zhwesky2010 added a commit to zhwesky2010/Paddle that referenced this pull request May 25, 2023
@zhwesky2010
[Zero-Dim] support ReshapeTransform/nll_loss/matmul support 0D (Paddl…
334bffd 
…ePaddle#53828)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzhang533 jzhang533 jzhang533 approved these changes

@jeff41404 jeff41404 jeff41404 approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhwesky2010 @jzhang533 @jeff41404 @XiaoguangHu01